[hotfix][network] Remove unused method BufferPool#getSubpartitionBuff…

…erRecyclers
TheodoreLx · Apr 28, 2021 · 5948039 · 5948039
1 parent d2cad34
commit 5948039
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java
@@ -61,6 +61,4 @@ public interface BufferPool extends BufferProvider, BufferRecycler {
 
     /** Returns the number of used buffers of this buffer pool. */
     int bestEffortGetNumOfUsedBuffers();
-
-    BufferRecycler[] getSubpartitionBufferRecyclers();
 }
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
@@ -18,7 +18,6 @@
 
 package org.apache.flink.runtime.io.network.buffer;
 
-import org.apache.flink.annotation.VisibleForTesting;
 import org.apache.flink.core.memory.MemorySegment;
 import org.apache.flink.runtime.io.network.buffer.BufferListener.NotificationResult;
 import org.apache.flink.util.ExceptionUtils;
@@ -659,12 +658,6 @@ private boolean isRequestedSizeReached() {
         return numberOfRequestedMemorySegments >= currentPoolSize;
     }
 
-    @VisibleForTesting
-    @Override
-    public BufferRecycler[] getSubpartitionBufferRecyclers() {
-        return subpartitionBufferRecyclers;
-    }
-
     private static class SubpartitionBufferRecycler implements BufferRecycler {
 
         private int channel;

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NoOpBufferPool.java b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NoOpBufferPool.java
@@ -22,8 +22,6 @@
 
 import org.apache.flink.core.memory.MemorySegment;
 
-import javax.annotation.Nullable;
-
 import java.util.concurrent.CompletableFuture;
 
 /** No-op implementation of {@link BufferPool}. */
@@ -98,12 +96,6 @@ public int bestEffortGetNumOfUsedBuffers() {
         throw new UnsupportedOperationException();
     }
 
-    @Nullable
-    @Override
-    public BufferRecycler[] getSubpartitionBufferRecyclers() {
-        return new BufferRecycler[0];
-    }
-
     @Override
     public void recycle(MemorySegment memorySegment) {
         throw new UnsupportedOperationException();