Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): missing notification controls when enabled from start #3898

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix(ios): missing notification controls when enabled from start #3898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9c4cb
fix(ios): notification controls don't show up when `true` from start
KrzysztofMoch Jun 12, 2024
0c7853f
lint code
KrzysztofMoch Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/basic/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ PODS:
- React-Mapbuffer (0.74.1):
- glog
- React-debug
- react-native-video (6.1.2):
- react-native-video (6.2.0):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -949,15 +949,15 @@ PODS:
- React-featureflags
- React-graphics
- React-ImageManager
- react-native-video/Video (= 6.1.2)
- react-native-video/Video (= 6.2.0)
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- react-native-video/Video (6.1.2):
- react-native-video/Video (6.2.0):
- DoubleConversion
- glog
- hermes-engine
Expand Down Expand Up @@ -1422,7 +1422,7 @@ SPEC CHECKSUMS:
React-jsitracing: 3de522f8f794dccd3c54af9160dc992ee65bd494
React-logger: 7e7403a2b14c97f847d90763af76b84b152b6fce
React-Mapbuffer: c5844bf3c2206f5475c0fc2340a89b049ea23c97
react-native-video: edecf23162492d4f41f96ff167684fc0507ca63a
react-native-video: 59f262a2d87c998b747ca1f031efb6eba1c156b5
React-nativeconfig: 21d89c65ca39875fad2c5c465e0e013e514eba21
React-NativeModulesApple: e2e180dae4486b2978fcf3564cc4c8de4b453a68
React-perflogger: 3d31e0d1e8ad891e43a09ac70b7b17a79773003a
Expand Down
4 changes: 2 additions & 2 deletions ios/Video/RCTVideo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,9 @@

@objc
func setShowNotificationControls(_ showNotificationControls: Bool) {
_showNotificationControls = showNotificationControls

guard let player = _player else {

Check failure on line 1108 in ios/Video/RCTVideo.swift

View workflow job for this annotation

GitHub Actions / Swift-Lint 

Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)
return
}

Expand All @@ -1112,8 +1114,6 @@
} else {
NowPlayingInfoCenterManager.shared.removePlayer(player: player)
}

_showNotificationControls = showNotificationControls
}

@objc
Expand Down
Loading