fix(android): playback doesn't work with 0 startPositionMs #3784
Conversation
| player.setMediaSource(mediaSource, startPositionMs); | ||
| } else { | ||
| player.setMediaSource(mediaSource, !haveResumePosition); | ||
| player.setMediaSource(mediaSource, false); |
There was a problem hiding this comment.
correct me if I am wrong, but the last else case should be:
player.setMediaSource(mediaSource, true );
?
| player.setMediaSource(mediaSource, false); | |
| player.setMediaSource(mediaSource, true); |
There was a problem hiding this comment.
This is the part that has changed.
If resetPosition is false, it use getCurrentPosition() internally.
I felt this behavior was more appropriate, so I fixed it.
There was a problem hiding this comment.
If you think it's better to guarantee the same behavior as before, I'll fix it.
There was a problem hiding this comment.
I was thinking the aim of this fix is to add the case with if (startPositionMs == 0) { ?
because here it is the normal use case ?!
There was a problem hiding this comment.
I think I'm wrong and it would be better to just fix the bug case. Thanks :)
f954358 to
3c57114
Compare
|
@freeboub @YangJonghun I have tiktok like app , where we scroll the videos, on android 9 S8 Samsung, some videos get stuck, now in my client phone two videos constantly stuck. while others are working, I just want to know whether this PR resolved this issue? |
|
@ZakirBangash let's try on 6.2 , will be released soon |
|
@freeboub Yes Please 🙏, We are in production App Nooberly, client reported this behaviour, Would be great help if we have this issue fixed. |
Summary
Some device(maybe low performance device) doesn't work with zero startPositionMs and DRM
(playback doesn't work before user trigger seek)
So I use resetPosition = true when startPositionMs is 0
Motivation
Changes
Test plan