-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Allow to configure styles for subtitle track #3662
Labels
Comments
did you try using : https://thewidlarzgroup.github.io/react-native-video/component/props#subtitlestyle ? |
@Sumeeth-24 Is the linked PR answer to your issue ? |
Hi Team,
Yes, the above PR has solved the issue and thanks everyone for the support
and effort put into it. Now the only obstacle or problem which we are
facing is of PipMode in Android. We are not able to play/pause the video in
pipmode and also not able to click on cross icon to close the video. Need
fix for this issue.
…On Fri, May 24, 2024 at 7:01 PM Olivier Bouillet ***@***.***> wrote:
@Sumeeth-24 <https://github.com/Sumeeth-24> Is the linked PR answer to
your issue ?
—
Reply to this email directly, view it on GitHub
<#3662 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AORM3RT5JEP6OK4BPV2ZXMDZD46MRAVCNFSM6AAAAABF3D7P3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGU2DKOJYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fix will be available in 6.1.3 |
Please see last merged PR. The proposed change was causing a regression, the original behavior has been restored, so in next release you will have to add a prop to configure it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Presently, our subtitle tracks lack the functionality to incorporate custom styles. Consequently, users encounter an inconvenience when attempting to pinch zoom to full screen, as the subtitle style becomes cropped and renders the subtitle track unreadable. For instance, if there are three lines of subtitles, upon entering full screen mode, only one line remains visible while the remaining two lines disappear below the screen. To address this issue, we require a solution that enables control over various configurations such as padding bottom, top, and other attributes. Additionally, implementing features like automatically centering subtitles when the video controller appears and shifting them downward when the controller is hidden would significantly enhance user experience. Therefore, the primary focus should be on introducing the basic feature of custom style customization for subtitle tracks.
Why it is needed ?
Users encounter an inconvenience when attempting to pinch zoom to full screen, as the subtitle style becomes cropped and renders the subtitle track unreadable. For instance, if there are three lines of subtitles, upon entering full screen mode, only one line remains visible while the remaining two lines disappear below the screen.
Possible implementation
Probably need additional props and make changes in native code.
Code sample
Code sample
The text was updated successfully, but these errors were encountered: