Skip to content

Commit

Permalink
fix(ios): destroy adsManager when player detach from super view (#3716)…
Browse files Browse the repository at this point in the history
… (#3722)

* fix(ios): destroy adsManager when player detach from super view (#3716)

* fix: swift format
  • Loading branch information
Khuongnb authored May 1, 2024
1 parent ecc946d commit e96c173
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
10 changes: 10 additions & 0 deletions ios/Video/Features/RCTIMAAdsManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,16 @@
}
}

func releaseAds() {
guard let adsManager else { return }
// Destroy AdsManager may be delayed for a few milliseconds
// But what we want is it stopped producing sound immediately
// Issue found on tvOS 17, or iOS if view detach & STARTED event happen at the same moment
adsManager.volume = 0
adsManager.pause()
adsManager.destroy()
}

// MARK: - Getters

func getAdsLoader() -> IMAAdsLoader? {
Expand Down
4 changes: 4 additions & 0 deletions ios/Video/RCTVideo.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1187,6 +1187,10 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
_resouceLoaderDelegate = nil
_playerObserver.clearPlayer()

#if USE_GOOGLE_IMA
_imaAdsManager.releaseAds()
#endif

self.removePlayerLayer()

if let _playerViewController {
Expand Down

0 comments on commit e96c173

Please sign in to comment.