feat (driver) implement our own LED driver #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobLichterfeld
previously approved these changes
Feb 4, 2023
…asumi/TesLight into feat/140-own-led-driver
|
Tested the current code for 24h now. I assume its stable. So I would say we can merge it after you approved. |
JakobLichterfeld
approved these changes
Feb 5, 2023
|
If this happens in the near future we can also wait😋. Having a second tester would be great. |
!= I get ... :-) |
|
Alright, then I am going for the merge now😜. The new driver is there🥳. Get ready for crashes and bugs. |
TheRealKasumi
added a commit
that referenced
this pull request
Mar 31, 2023
* Add from internal repo * Remove c-style casts * Fix stale LEDs * Minor stuff like comments * Update TesLight.cpp * Small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #140
closes #98
partially closes #134
Its finally here, our own driver for WS2812(B) LEDs. With that we remove the FastLED dependency and potentially a lot of problems which startet when we included it. The performance with the new driver has roughly doubled while the memory consumption was also slightly reduced. The CPU load also reduced drastically since we are using DMA with the I2S hardware. So far it seems perfectly stable but I am still in the process of testing. There might be smaller improvements to the way how pixels are accessed but this is more about... "making it look nicer" while not changing anything functional.
Also note that this potentially seems to close #66. So if we don't encounter this again I would guess we close it in the future. Alright, I guess all this is pretty good news.