Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore rework #1503

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Gitignore rework #1503

merged 9 commits into from
Feb 13, 2025

Conversation

iluha168
Copy link
Contributor

@iluha168 iluha168 commented Feb 9, 2025

  • Deduplicates idential config files in the repo
  • Adds dev-community-proposed gitignores
    • Pack switching
    • Probe JS v7

@iluha168 iluha168 marked this pull request as ready for review February 9, 2025 08:38
Copy link
Collaborator

@Xefyr0 Xefyr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a way to do this that doesn't involve copying all of the files to/from config overrides in this commit and every build/mode switch. That's over 300 files to modify every time.

@iluha168 iluha168 force-pushed the git-and-pack-mode-rework branch from 828b671 to 7c492fe Compare February 10, 2025 05:14
This works because git will track files already in the repository. New configs can be added with `git add --force`.
@iluha168 iluha168 requested a review from Xefyr0 February 10, 2025 05:32
@Xefyr0 Xefyr0 merged commit c5eec7f into ThePansmith:main Feb 13, 2025
@iluha168 iluha168 deleted the git-and-pack-mode-rework branch February 13, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants