Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uwsgi log file permissions (PP-2067) #2247

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

jonathangreen
Copy link
Member

@jonathangreen jonathangreen commented Jan 14, 2025

Description

This builds on the changes from #2077. It moves setting permissions on the log files from container build time to run time for both uwsgi and nginx logs. That way if the logs volume is mounted in a host system, we still get the correct log permissions at run time.

Motivation and Context

JIRA: PP-2067

After the recent docker host system ubuntu upgrade, our logs are not being created with the correct permissions.

How Has This Been Tested?

  • Tested locally with docker

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen force-pushed the bugfix/uwsgi-log-folder branch from 1fe401e to 889b94d Compare January 14, 2025 15:41
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎸

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (d7d9040) to head (889b94d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2247   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         363      363           
  Lines       41296    41296           
  Branches     8840     8840           
=======================================
  Hits        37628    37628           
  Misses       2406     2406           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen merged commit 0c52aaa into main Jan 14, 2025
21 checks passed
@jonathangreen jonathangreen deleted the bugfix/uwsgi-log-folder branch January 14, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants