Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP-2065] Address library not persistent within session errors by ens… #2246

Merged

Conversation

dbernstein
Copy link
Contributor

@dbernstein dbernstein commented Jan 13, 2025

…uring the

library and other objects accessed within the new transaction are attached to the session.

Description

I was using session.refresh(obj) instead of session.merge(obj). merge reattaches a detached object to the session where refresh refreshes an object that is already associated with the session.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-2065

How Has This Been Tested?

To be verified on Minotaur.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

…uring the

library and other objects accessed within the new transaction are attached to the session.
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (9bd47a3) to head (a26f936).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         363      363           
  Lines       41296    41296           
  Branches     8840     8840           
=======================================
  Hits        37628    37628           
  Misses       2406     2406           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@dbernstein dbernstein merged commit d7d9040 into main Jan 13, 2025
21 checks passed
@dbernstein dbernstein deleted the PP-2065-fix-non-persistent-library-error-on-event-collection branch January 13, 2025 21:25
dbernstein added a commit that referenced this pull request Jan 14, 2025
…uring the (#2246)

library and other objects accessed within the new transaction are attached to the session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants