Allow empty string for username and password in ODL settings.

[dbernstein]

Description

A follow-on PR for https://ebce-lyrasis.atlassian.net/browse/PP-1834 to address validation error in ODL 2.0 collection config when no specifying username and password. Validation requires a string albeit empty for a string type control. Changing the return type had undesirable ripple effects. This changes the default value from None to an empty string which seemed to me the more straightforward solution.

Motivation and Context

How Has This Been Tested?

I tested it manually on my local instance.

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (f417b02) to head (a70fc49).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2245   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         363      363           
  Lines       41296    41296           
  Branches     8840     8840           
=======================================
  Hits        37628    37628           
  Misses       2406     2406           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonathangreen]

Looks fine. I would have thought that changing the type of password to be str | None would be a better solution for consistency since the base class for the OPDS settings defines them like that, since authentication is optional there:

circulation/src/palace/manager/core/opds_import.py

Lines 157 to 177 in b4d189b

	username: str | None = FormField(
	None,
	form=ConfigurationFormItem(
	label=_("Username"),
	description=_(
	"If HTTP Basic authentication is required to access the OPDS feed (it usually isn't), enter the username here."
	),
	weight=-1,
	),
	)
	password: str | None = FormField(
	None,
	form=ConfigurationFormItem(
	label=_("Password"),
	description=_(
	"If HTTP Basic authentication is required to access the OPDS feed (it usually isn't), enter the password here."
	),
	weight=-1,
	),
	)

But I haven't tried making this type change, so maybe there are some consequences I'm not thinking about.