Update how we load settings from database #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 231 231
Lines 29524 29524
Branches 6897 6897
=======================================
+ Hits 26697 26698 +1
+ Misses 1798 1797 -1
Partials 1029 1029
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
2 tasks
396331e to
8083879
Compare
dbernstein
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
@jonathangreen : looks good. I don't fully understand the intricacies of the test code changes, but I trust that those are required by the change to base.py.
tdilauro
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Update how we load settings from database. * Make sure config data in tests validates * More test fixes * Mypy fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load our settings from the database with full validation, rather then short-cutting that using the
construct()method.Motivation and Context
@dbernstein noted in #1495 that we had a problem in our sip2 integration where settings were not being loaded with the proper enum types from the database. This turned out to be a more pervasive problem then just for that integration, and necessitated this fix.
How Has This Been Tested?
Tested with the SIP2 code where this problem was first noted and ran unit tests.
Checklist