Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audiobook time tracking #1288
Audiobook time tracking #1288
Changes from 8 commits
b5e58f3
3d43dca
e1a00a5
22d74c2
22bcfe5
d735181
4b0cfcd
edf3756
0b51149
0705167
23c5e51
1a1c9a0
e081f78
4a35980
fd0e97a
30b0661
c5c942d
87ad147
6827875
6a93da8
49170e5
6e727b6
049696b
3a0a689
c9e8a21
dc8d552
ba1fa75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising
ValueError
here causes the entire request to fail, even if only onetimeEntry
of many has an error. Ideally, we'd return this as a 400 response for just this entry.I think it's unlikely for this to happen to one among many, so I think we can address this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
book_id
andlibrary_id
from the spec are missing here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to fix this.