Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/v3 #85

Open
wants to merge 125 commits into
base: main
Choose a base branch
from
Open

Rewrite/v3 #85

wants to merge 125 commits into from

Conversation

TheDrone7
Copy link
Owner

@TheDrone7 TheDrone7 commented Jan 3, 2024

A full rewrite of the main library using the new separated packages.

Progress tracking

  • Client

DDragon (add support for storage)

  • Champions
  • Items
  • Runes
  • Summoner Spells
  • Arena Augments
  • Challenges

API (full rewrite)

  • Account
  • Champion-Mastery
  • Champion
  • Clash
  • League
  • Challenges
  • Status
  • Match
  • Spectator
  • Summoner
  • T-stub
  • Tournament

More features

  • Complex caching (conditional by function per object)
  • Improved storage (verification system)

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 2c843d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
shieldbow Minor
@shieldbow/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 73.37901% with 1088 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (e232940) to head (6e11c87).

Current head 6e11c87 differs from pull request most recent head e2982ba

Please upload reports for the commit e2982ba to get more accurate results.

Files Patch % Lines
.../shieldbow/src/structures/spectator/participant.ts 24.10% 148 Missing ⚠️
packages/shieldbow/src/structures/league/entry.ts 14.38% 125 Missing ⚠️
packages/shieldbow/src/structures/league/item.ts 23.80% 96 Missing ⚠️
packages/shieldbow/src/structures/summoner.ts 28.70% 77 Missing ⚠️
packages/shieldbow/src/structures/mastery.ts 27.27% 72 Missing ⚠️
packages/shieldbow/src/managers/api/account.ts 68.48% 51 Missing and 1 partial ⚠️
packages/shieldbow/src/managers/api/challenge.ts 86.68% 46 Missing and 5 partials ⚠️
...ges/shieldbow/src/structures/spectator/featured.ts 38.27% 50 Missing ⚠️
packages/shieldbow/src/structures/league/list.ts 26.98% 46 Missing ⚠️
...ckages/shieldbow/src/structures/spectator/runes.ts 30.15% 44 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   93.27%   83.41%   -9.87%     
==========================================
  Files          62      112      +50     
  Lines        4684     9102    +4418     
  Branches      563     1142     +579     
==========================================
+ Hits         4369     7592    +3223     
- Misses        302     1468    +1166     
- Partials       13       42      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant