Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauled b:poll #788

Merged
merged 4 commits into from
May 20, 2017
Merged

Overhauled b:poll #788

merged 4 commits into from
May 20, 2017

Conversation

jepsar
Copy link
Contributor

@jepsar jepsar commented May 20, 2017

  • Component can now be safely updated (previous interval is cleared).
  • Added stop attribute (to stop poll on update).
  • Added widgetVar attribute.
  • Added widgetVar.stop() JavaScript function.
  • update and execute are now processed using ExpressionResolver. Note: this might break previous usages (where update and execute were used as is), but this really was a bug. This must be an upgrade note.
  • Added PropertyKeys and getters and setters.

jepsar added 4 commits May 20, 2017 08:09
Mainly to update *.jsfdsl changes
* Added stop attribute.
* Added widgetVar.
* Added widgetVar.stop() JS function.
* Update and execute are now processed using ExpressionResolver.
@stephanrauh stephanrauh merged commit 3bedcc0 into TheCoder4eu:master May 20, 2017
@stephanrauh
Copy link
Collaborator

Thanks! Funny thing is that the showcase itself was broken by using the ExpressionResolver. For some reason unknown, there was a third b:poll in the demo. It was never shown, but it didn't matter because of the faulty implementation of the update attribute :).

@jepsar
Copy link
Contributor Author

jepsar commented May 21, 2017

Ah, I now understand what the once attribute was supposed to do.

Component can now be safely updated (previous interval is cleared).

This makes the once attribute obsolete.

I saw you already did some work on the documentation. I'll be adding the missing attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants