Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS for select with other field sizes #1119

Merged
merged 6 commits into from
May 3, 2020
Merged

Fix CSS for select with other field sizes #1119

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e88680
Note added
sebsoftware Dec 12, 2019
2578218
Fixed typo
sebsoftware Dec 12, 2019
7221889
Fixed typo
sebsoftware Dec 12, 2019
a00565b
Merge remote-tracking branch 'upstream/master' into base
sebsoftware Jan 14, 2020
fdabfec
Fix CSS for select with other field sizes
sebsoftware Jan 14, 2020
bb18651
Revert change
sebsoftware Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions gradleResources/staticResources/css/bsf.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,15 @@ background-image: url("data:image/svg+xml;charset=utf-8,%3Csvg%20version%3D%221.
appearance: none;
}

select.input-sm {
line-height: 20px;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better then line-height: 30px; of core.css 👍


select.input-lg {
line-height: 26px;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better then the line-height: 46px; of core.css 👍


select.form-control {
background-image: url("data:image/svg+xml;charset=utf-8,%3Csvg%20version%3D%221.1%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20xmlns%3Axlink%3D%22http%3A%2F%2Fwww.w3.org%2F1999%2Fxlink%22%20x%3D%220px%22%20y%3D%220px%22%20fill%3D%22%23555555%22%20%0A%09%20width%3D%2224px%22%20height%3D%2224px%22%20viewBox%3D%22-261%20145.2%2024%2024%22%20style%3D%22enable-background%3Anew%20-261%20145.2%2024%2024%3B%22%20xml%3Aspace%3D%22preserve%22%3E%0A%3Cpath%20d%3D%22M-245.3%2C156.1l-3.6-6.5l-3.7%2C6.5%20M-252.7%2C159l3.7%2C6.5l3.6-6.5%22%2F%3E%0A%3C%2Fsvg%3E");
padding-right: 25px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}