Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enable value attribute for b:inputSecret #841

Closed
mtvweb opened this issue Aug 19, 2017 · 3 comments
Closed

Re-Enable value attribute for b:inputSecret #841

mtvweb opened this issue Aug 19, 2017 · 3 comments
Assignees
Milestone

Comments

@mtvweb
Copy link

mtvweb commented Aug 19, 2017

I have detected that since 1.1.2 the value attribute for inputSecret is not rendered any more.
I agree it is a security reason, but in my opinion it should be handled by the value bean and not by the component.

I often use value to put a pseudo value into the password fields to indicate that a password is set, i.E. value="*****" in a profile form. So I can detect that it is changed if it is not the value any more. Without rendering the value a secret field always seems to be empty.

It is easy enough to reset value in the bean after logging in or sthg. else to "" or "****" for security.

That's my opinion.

@stephanrauh
Copy link
Collaborator

Fair enough. However, I don't want to return to the original implementation. Now it shows an empty input field if there's no value, and eight asterisks if there's a value. The decode() method ignores the eight asterisks, so the password isn't set inadvertently.

How do you like this idea?

@stephanrauh stephanrauh added this to the v1.1.3 milestone Aug 19, 2017
@stephanrauh stephanrauh self-assigned this Aug 19, 2017
@mtvweb
Copy link
Author

mtvweb commented Aug 19, 2017

Why not an attribute "ignoreValue" with default "true", which will enable the possibility to switch back to the old behaviour.

stephanrauh added a commit that referenced this issue Aug 22, 2017
… client if the programmer insists on doing so
stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Aug 22, 2017
@stephanrauh
Copy link
Collaborator

I've implemented the feature. The attribute is called render-value. The default value is false.

I didn't include it in the taglib yet. I hope you're using an IDE that doesn't mind. My current copy of the taglib already contains a half-finished new component, so I don't want to publish it yet.

stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants