Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b:canvas needs wrapper div when using responsive features #711

Closed
ggam opened this issue Apr 19, 2017 · 2 comments
Closed

b:canvas needs wrapper div when using responsive features #711

ggam opened this issue Apr 19, 2017 · 2 comments
Assignees
@ggam @stephanrauh @TheCoder4eu
Labels
bug confirmed Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Milestone
v1.4.2

Comments

@ggam
Copy link
Collaborator

ggam commented Apr 19, 2017

Seems like I forgot b:canvas on #694

Additionaly, a width:100% should be added to the element when using them, so the canvas goes full width. That CSS should be moved to a new class so the user can still override it using style.
@ggam
Copy link
Collaborator Author

ggam commented Apr 20, 2017

This may also need some JS to adjust width (see https://github.com/szimek/signature_pad#handling-high-dpi-screens)

@TheCoder4eu TheCoder4eu self-assigned this Jun 10, 2018
@TheCoder4eu TheCoder4eu added this to the v1.5.0 milestone Jun 10, 2018
stephanrauh added a commit that referenced this issue Aug 4, 2019
@stephanrauh
#711 added the responsive design wrapper class
d7b0fdf
stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Aug 4, 2019
@stephanrauh
TheCoder4eu/BootsFaces-OSP#711 added an example for responsive design
4ce9642
@stephanrauh
Copy link
Collaborator

Now responsive design seems to work well. Thanks for the hint!

@stephanrauh stephanrauh added bug confirmed Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation. and removed enhancement under consideration labels Aug 4, 2019
@stephanrauh stephanrauh self-assigned this Aug 4, 2019
@TheCoder4eu TheCoder4eu modified the milestones: v1.5.0, v1.4.2 Aug 28, 2019
@TheCoder4eu TheCoder4eu mentioned this issue Aug 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggam ggam

@stephanrauh stephanrauh

@TheCoder4eu TheCoder4eu

Labels
bug confirmed Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Projects
None yet
Milestone
v1.4.2
Development

No branches or pull requests
3 participants
@ggam @stephanrauh @TheCoder4eu