Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render all label-col-xx classes in horizontal mode #605

Closed
NicolaIsotta opened this issue Jan 3, 2017 · 2 comments
Closed

Render all label-col-xx classes in horizontal mode #605

NicolaIsotta opened this issue Jan 3, 2017 · 2 comments
Assignees
Milestone

Comments

@NicolaIsotta
Copy link
Contributor

Right now, only one of the classes specified by the user is rendered: for example, if I have a b:inputText with label-col-sm="4" label-col-md="3" label-col-lg="2" the generated html contains this: <label class="bf-no-message has-success col-md-3 control-label" [...] >.
The issue is in the class net.bootsfaces.render.Responsive, method getResponsiveLabelClass: the strings for the col-xx classes should be combined in a StringBuilder.

@stephanrauh stephanrauh self-assigned this Jan 3, 2017
@stephanrauh stephanrauh added this to the v1.1.0 milestone Jan 3, 2017
@stephanrauh
Copy link
Collaborator

Good point. I've fixed that. Thanks!

@stephanrauh
Copy link
Collaborator

I've published a developer snapshot on Maven Central. As usual, see #369 on how to get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants