Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b:NavBar brand-image aligned incorrectly #1050

Closed
sometowngeek opened this issue Jan 9, 2019 · 4 comments · Fixed by #1145
Closed

b:NavBar brand-image aligned incorrectly #1050

sometowngeek opened this issue Jan 9, 2019 · 4 comments · Fixed by #1145
Assignees
Milestone

Comments

@sometowngeek
Copy link

sometowngeek commented Jan 9, 2019

Versions

  • BootsFaces: 1.4.2
  • Browser: Internet Explorer 11.2x
  • JSF: 2

Dilemma

I am having trouble getting the image aligned.

brand image not aligned

  • The image shows alignment of the icon.

I tried following the documentation and haven't had any luck on making sure it's aligned properly.

It would be nice if the <b:navBar ... > would make sure there is enough padding/margin to make sure the div tag encompasses the whole content.

This is the MCVE code I used:

    <b:row>
        <b:navBar brandHref="#"
            brandImg="/something/resources/images/dummyLogo.tif" fluid="true">
            <b:form styleClass="navbar-form navbar-left">
                <div class="form-group">
                        <input type="text" class="form-control" />   
                </div>
                <button type="submit" class="btn btn-default">Submit</button>
            </b:form>
            <!-- Following line is needed for TBS 3.0.1 (panel content overflow issue) -->
            <b:navbarLinks pull="right">
                <b:navLink value="    " href="#"></b:navLink>
            </b:navbarLinks>
            <b:navbarLinks pull="right" styleClass="hidden-xs">
                    <b:navLink value="Link" href="#"></b:navLink>
                    <b:dropMenu value="Dropdown">
                      <b:navLink value="Action" href="#"></b:navLink>
                      <b:navLink value="Another action" href="#"></b:navLink>
                      <b:navLink value="Something else here" href="#"></b:navLink>
                      <b:navLink></b:navLink>
                      <b:navLink header="Nav header"></b:navLink>
                      <b:navLink value="Separated link" href="#"></b:navLink>
                      <b:navLink value="One more separated link" href="#"></b:navLink>
                    </b:dropMenu>
            </b:navbarLinks>
        </b:navBar>
    </b:row>

I think the same thing happens with <b:navBar brand="Foo" ...>

It would be nice to see this bug fixed. :)

@sometowngeek
Copy link
Author

Hold on... Don't start researching this yet. I just found something interesting about the code. I'll keep you posted.

@sometowngeek
Copy link
Author

Yeah, I still have this issue. Although, my workaround is adding image-style="margin-top:-15px;" attribute to <b:navBar ...>.

Is the navBar supposed to keep the image in the center or does it just offset it?

@geopossachs geopossachs self-assigned this May 17, 2020
@geopossachs geopossachs added this to the v1.5.0 milestone May 17, 2020
@geopossachs
Copy link
Collaborator

i found in BF 4.0 the css style for the image with vertical-align: top; display: inline-block;

@geopossachs
Copy link
Collaborator

geopossachs commented Jun 3, 2020

@sometowngeek can to try via brandImgStyle if the image need 'vertical-align: top' or / and 'display: inline-block'?

@geopossachs geopossachs added the css label Jun 3, 2020
geopossachs added a commit to geopossachs/BootsFaces-OSP that referenced this issue Jun 3, 2020
@geopossachs geopossachs linked a pull request Jul 30, 2020 that will close this issue
@TheCoder4eu TheCoder4eu modified the milestones: v1.5.0, v1.6.0 Aug 8, 2020
TheCoder4eu pushed a commit that referenced this issue Aug 8, 2020
#1050 set fixed css style for navbar brand image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants