Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TARGET path handling #10

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Conversation

tomslobodnik
Copy link
Contributor

mkstage4 stopped working for me after commit d1372b0 by

  1. being dependent on current working directory, and
  2. not matching default exclude patterns because of double slash prefix when used with -s option

Following change works with both -s and -t options (gentoo, tar 1.29, bash 4.4.12). When -t is used, trailing slash is added if not present to make solution universal.

@TheChymera
Copy link
Owner

Looking good!

As mentioned in another PR having some tests for this would prevent commits unintentionally breaking some popular use cases. Would you like to help out with this? Ideally we would be looking for some unit tests which can use gentoo images.

@TheChymera TheChymera merged commit a026ef0 into TheChymera:master Mar 22, 2017
@tomslobodnik
Copy link
Contributor Author

I agree having tests is important to prevent simple changes breaking down the script. I would like to help, but can't promise anything due to my very limited free time and lack of experience with CI and unit testing. If you have more specific idea about the tests, it would help me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants