Use InvariantCulture for float parsing #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Depending on the culture, C# chooses the decimal separator to be either
,
or.
. For example, for the russian culture, it uses,
. And since Tiled Map Format uses.
(for variables such as x, y, width, height, offsetX and offsetY), it throws an exception that the parsing failed.Solution
Using an invariant
CultureInfo
,float.TryParse()
will use.
for the decimal separator, which will not throw an exception.