Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦈 IMP: Better CMake CPM Installation Logging #22

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

TheBlackPlague
Copy link
Owner

🎯 Summary

This PR improves the CMake Script that handles CPM installation. The key improvements are related to more logging and a network-error handling attempt system.

👏 Acknowledgements

NA

📈 ELO

NA

This is useful in debugging possible network conditional errors.

Bench: 7489006
@TheBlackPlague TheBlackPlague added = ELO This change doesn't alter ELO. = DOC This change doesn't improve the documentation. labels Jun 26, 2023
@TheBlackPlague TheBlackPlague self-assigned this Jun 26, 2023
@TheBlackPlague TheBlackPlague marked this pull request as ready for review June 26, 2023 09:26
@TheBlackPlague TheBlackPlague merged commit cd54bab into master Jun 26, 2023
@TheBlackPlague TheBlackPlague deleted the better-cpm-logging branch June 26, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
= DOC This change doesn't improve the documentation. = ELO This change doesn't alter ELO.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant