Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rgb_cmyk_conversion #831

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

ali77gh
Copy link
Contributor

@ali77gh ali77gh commented Oct 23, 2024

RGB to CMYK conversion

Description

RGB to CMYK Color format algorithm is implemented.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@ali77gh ali77gh requested review from imp2002 and vil02 as code owners October 23, 2024 19:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.42%. Comparing base (c906255) to head (efbe4af).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   95.41%   95.42%           
=======================================
  Files         314      315    +1     
  Lines       22783    22806   +23     
=======================================
+ Hits        21739    21762   +23     
  Misses       1044     1044           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/conversions/rgb_cmyk_conversion.rs Outdated Show resolved Hide resolved
src/conversions/rgb_cmyk_conversion.rs Outdated Show resolved Hide resolved
ali77gh and others added 2 commits October 29, 2024 23:23
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
@ali77gh
Copy link
Contributor Author

ali77gh commented Oct 29, 2024

Ops!
CI failed.
I will make another commit to fix it ASAP.

@ali77gh ali77gh requested a review from vil02 October 30, 2024 16:51
@vil02 vil02 merged commit 3422002 into TheAlgorithms:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants