-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result file changes #67
Comments
I'm going to change 'Done File' nomenclature to 'Result File' / 'Export Result File'. It's more descriptive. Some of the key names will change to be more consistent and descriptive as well. |
This is done and will be in 0.2.6. The possible result json file contents are below. Not all keys will be present of course, only the ones relevant to the export profile used. These key names also should not be checked using string literals. Instead, the key name can be fed into MarkersExtractor/Sources/MarkersExtractor/Export/Result/ExportResult.swift Lines 47 to 53 in 45408b6
Key/Value Pairs
|
Will close this for now. |
The following modifications to the result file (formerly known as 'done' file) are needed:
profile
containing the profile name as the valueReferenced from: Proper Error message and handling for mismatched Profiles and Database MarkerData#9
exportFolder
containing the final output path of the extracted files--done-filename
CLI option (MarkersExtractor.doneFilename
) to--result-file-path
(MarkersExtractor.resultFilePath
) which can accept a full path.That way shell tools can know where to find the done file and in turn it can tell them where the final output folder is.
Referenced from: Database Panel Implementation MarkerData#16
--create-done-file
flag as it will be redundant with the--result-file-path
option. If--result-file-path
is provided, it implicitly means that a done file should be created. If not supplied, no done file is created.The text was updated successfully, but these errors were encountered: