fix: remove EmptyCard default values for width and height

The-ring-io · Sep 11, 2019 · 5d60c76 · 5d60c76
1 parent 2c7e8fc
commit 5d60c76
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 13 deletions.
diff --git a/example/lib/screens/card_grid_screen.dart b/example/lib/screens/card_grid_screen.dart
@@ -32,7 +32,7 @@ class _CardGridScreenState extends State<CardGridScreen> {
                     columnCount: columnCount,
                     position: index,
                     duration: const Duration(milliseconds: 375),
-                    child: ScaleAnimation(
+                    child: const ScaleAnimation(
                       scale: 0.5,
                       child: FadeInAnimation(
                         child: EmptyCard(),

diff --git a/example/lib/widgets/empty_card.dart b/example/lib/widgets/empty_card.dart
@@ -6,8 +6,8 @@ class EmptyCard extends StatelessWidget {
 
   const EmptyCard({
     Key key,
-    this.width = 100,
-    this.height = 100,
+    this.width,
+    this.height,
   }) : super(key: key);
 
   @override

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -40,7 +40,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.0.1"
+    version: "0.1.1"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -81,13 +81,6 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.0.3"
-  shrine_images:
-    dependency: "direct main"
-    description:
-      name: shrine_images
-      url: "https://pub.dartlang.org"
-    source: hosted
-    version: "1.1.1"
   sky_engine:
     dependency: transitive
     description: flutter

diff --git a/lib/src/animation_executor.dart b/lib/src/animation_executor.dart
@@ -26,7 +26,6 @@ class AnimationExecutor extends StatefulWidget {
 class _AnimationExecutorState extends State<AnimationExecutor>
     with SingleTickerProviderStateMixin {
   AnimationController _animationController;
-
   Timer _timer;
 
   @override
@@ -37,7 +36,7 @@ class _AnimationExecutorState extends State<AnimationExecutor>
         AnimationController(duration: widget.duration, vsync: this);
 
     if (AnimationLimiter.shouldRunAnimation(context) ?? true) {
-      _timer = Timer(widget.delay,  () => _animationController.forward());
+      _timer = Timer(widget.delay, () => _animationController.forward());
     } else {
       _animationController.value = 1.0;
     }