Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Output #68

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Save Output #68

merged 8 commits into from
Oct 11, 2023

Conversation

The-Ludwig
Copy link
Owner

@The-Ludwig The-Ludwig commented Oct 11, 2023

fixes #60
Adds an option to save the std output from corsika.
Also bumps the version to 0.6. (Changes are backward compatible, but it is a new feature, so a new minor version feels right)

@The-Ludwig The-Ludwig requested a review from Jean1995 October 11, 2023 08:09
@The-Ludwig The-Ludwig mentioned this pull request Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #68 (b4e0af9) into main (31f0e3f) will decrease coverage by 0.16%.
Report is 6 commits behind head on main.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   92.56%   92.40%   -0.16%     
==========================================
  Files          15       15              
  Lines         753      777      +24     
==========================================
+ Hits          697      718      +21     
- Misses         56       59       +3     
Files Coverage Δ
panama/cli/run.py 82.35% <100.00%> (+0.35%) ⬆️
panama/fluxes/cosmic_ray_fluxes.py 94.96% <100.00%> (ø)
panama/run.py 94.30% <87.50%> (-1.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@The-Ludwig The-Ludwig merged commit 7ab5a2e into main Oct 11, 2023
@The-Ludwig The-Ludwig deleted the save_output branch October 11, 2023 09:23
The-Ludwig added a commit that referenced this pull request Nov 9, 2023
* add save std

* fix cli bug

* fix bugs

* fix timeout stdout bug

* Bump Version

* fix ruff errors

* add test for save_output

* fix ruff errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save STDOUT
1 participant