Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions required to make use of Airflow TaskGroups and test them #642

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Sep 27, 2023

Add functions required to make use of Airflow TaskGroups and test them

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (b94c968) 87.39% compared to head (956c5e7) 87.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #642      +/-   ##
===========================================
- Coverage    87.39%   87.14%   -0.25%     
===========================================
  Files           34       34              
  Lines         4680     4691      +11     
  Branches       572      572              
===========================================
- Hits          4090     4088       -2     
- Misses         474      486      +12     
- Partials       116      117       +1     
Files Coverage Δ
...latform/observatory/platform/workflows/workflow.py 73.00% <25.00%> (-0.98%) ⬇️
...rm/observatory/platform/observatory_environment.py 84.62% <45.45%> (-0.87%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jamie, these changes look good. I'm looking forward to changing the dag construction of the telescopes!

@keegansmith21 keegansmith21 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into develop with commit 9a6ad37 Oct 3, 2023
@jdddog jdddog deleted the feature/airflow-taskgroup-functions branch October 20, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants