Fix/Install Packer plugins when building the observatory image #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #641 +/- ##
===========================================
+ Coverage 87.14% 87.16% +0.01%
===========================================
Files 34 34
Lines 4691 4697 +6
Branches 572 572
===========================================
+ Hits 4088 4094 +6
Misses 486 486
Partials 117 117
☔ View full report in Codecov by Sentry. |
| """Install the necessary plugins for packer.""" | ||
|
|
||
| # Install the Packer plugins by doing an init on the observatory image config file | ||
| args = ["packer", "init", "observatory-image.json.pkr.hcl"] |
There was a problem hiding this comment.
Is the image config file always in the same directory that the packer script is being run? Would it be better to supply the absolute path?
There was a problem hiding this comment.
It is OK because the current working directory is set below cwd=self.terraform_build_path
acd7369 to
90926b8
Compare
jdddog
approved these changes
Oct 3, 2023
| """Install the necessary plugins for packer.""" | ||
|
|
||
| # Install the Packer plugins by doing an init on the observatory image config file | ||
| args = ["packer", "init", "observatory-image.json.pkr.hcl"] |
There was a problem hiding this comment.
It is OK because the current working directory is set below cwd=self.terraform_build_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add this with the recent Packer upgrade. The new observatory-image.json.pkr.hcl file relies on external plugins to be installed first before the observatory-image can be built. I did this manually before when I upgraded so I missed it adding it to the platform.
I've tested it with a fresh Packer installation and I've added a unit test to suit.
Please review and edit as needed.