Feature/Create buckets with roles for unit tests #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #639 +/- ##
===========================================
+ Coverage 87.16% 87.26% +0.10%
===========================================
Files 34 34
Lines 4697 4704 +7
Branches 572 574 +2
===========================================
+ Hits 4094 4105 +11
+ Misses 486 483 -3
+ Partials 117 116 -1
☔ View full report in Codecov by Sentry. |
keegansmith21
previously approved these changes
Sep 28, 2023
jdddog
added a commit
that referenced
this pull request
Feb 25, 2024
Co-authored-by: Jamie Diprose <5715104+jdddog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some workflows, usage of Google storage buckets require explicit roles and permissions. For example, OpenAlex requires the following permissions for transferring data between AWS and GCS:
These roles are now needed to be explicitly added to buckets, otherwise unit tests will fail due to permission issues. This PR adds the ability to create Google storage buckets with specific roles for usage in unit tests.
Buckets are now added to the ObservatoryEnvironment class as a data dictionary where the keys are the bucket_ids and the values are a set of roles required. I have added the roles in such a way that it should not interfere with existing unit tests for the academic observatory workflows.