Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dag_run_id nullable in openapi.yaml #631

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Aug 16, 2023

A fix for the error:

observatory.api.client.exceptions.ApiTypeError: Invalid type for variable 'dag_run_id'. Required value type is str and passed type was NoneType at ['received_data'][0]['dag_run_id']

@jdddog jdddog requested a review from keegansmith21 August 16, 2023 05:46
Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on to this Jamie!

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (af7b83c) 86.61% compared to head (70e9ce5) 86.68%.
Report is 1 commits behind head on develop.

❗ Current head 70e9ce5 differs from pull request most recent head 65b48c9. Consider uploading reports for the commit 65b48c9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #631      +/-   ##
===========================================
+ Coverage    86.61%   86.68%   +0.06%     
===========================================
  Files           34       34              
  Lines         4626     4626              
  Branches       559      559              
===========================================
+ Hits          4007     4010       +3     
+ Misses         505      502       -3     
  Partials       114      114              
Files Changed Coverage Δ
...pi/observatory/api/client/model/dataset_release.py 85.29% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdddog jdddog force-pushed the fix/api-dag-run-id-nullable branch from 70e9ce5 to 65b48c9 Compare August 18, 2023 04:31
@jdddog jdddog merged commit d2a432f into develop Aug 21, 2023
@jdddog jdddog deleted the fix/api-dag-run-id-nullable branch August 21, 2023 03:58
jdddog added a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants