-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INF-465: Cloud Endpoints Portal Deprecation - move observatory-api container #610
Conversation
c053fa2
to
d15b54f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #610 +/- ##
===========================================
- Coverage 91.97% 91.91% -0.07%
===========================================
Files 48 48
Lines 6640 6565 -75
Branches 758 753 -5
===========================================
- Hits 6107 6034 -73
- Misses 413 415 +2
+ Partials 120 116 -4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex, your PR looks good, I've just got a few small suggestions.
These files can be removed:
- .github/workflows/build-observatory-api.yml
- observatory-api/Dockerfile
- observatory-api/requirements.cloudrun.txt
Then in terraform_builder.py
, the function make_open_api_template
and any calls to it can be removed as well as the import for OpenApiRenderer. This isn't needed anymore since the openapi.yaml file is rendered when the API server is started.
@@ -16,6 +16,7 @@ | |||
version: '3.8' | |||
|
|||
x-environment: &environment | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex, the changes look good.
On March 21st, the Developer portal for Google APIs is being deprecated and we will not have access to a production API gui where we can easily check or modify Observatory API data.
This PR is to move the deployment of the observatory-api container from Google's Cloud Run service to a local docker container that runs on the main and worker VM of the deployed Observatory Platform. In doing so, we will be able to access the Swagger UI by ssh'ing into the main VM and going to http://localhost:5002/ui . The local observatory-api container will still have access to the Cloud DB instance, where all of the release and workflow data is stored.
The API gateway and the serverless VPC service have also been removed as they were only needed for the Cloud Run instance to access data from the Cloud DB instance that holds the observatory API data.