Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Docker Compose V2 #602

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Feb 16, 2023

Upgrade Docker Compose to V2 as V1 won’t be supported from the end of June 2023 and will be removed from all Docker Desktop versions.

I've also updated a number of related things:

  • Updated docs with Docker Compose V2 changes and Ubuntu install script.
  • For VMs:
    • Updated VM image to Ubuntu 22.04 (Ubuntu 18.04 is end of life).
    • Updated Berglas to v1.0.1.
  • Terraform:
    • Tidied up the firewall rules, which had to be updated after hashicorp/google updated.
    • Add versions restraints to the terraform/versions.tf so that the Terraform providers don't update to a new version without us doing it, which causes problems.

I've tested deploying the system to the cloud.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 91.98% // Head: 91.98% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (608c0fd) compared to base (f2b125b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #602      +/-   ##
===========================================
- Coverage    91.98%   91.98%   -0.01%     
===========================================
  Files           48       48              
  Lines         6601     6599       -2     
  Branches       751      751              
===========================================
- Hits          6072     6070       -2     
  Misses         413      413              
  Partials       116      116              
Impacted Files Coverage Δ
...servatory-platform/observatory/platform/cli/cli.py 82.51% <100.00%> (-0.29%) ⬇️
...form/observatory/platform/docker/compose_runner.py 100.00% <100.00%> (ø)
...orm/observatory/platform/docker/platform_runner.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdddog jdddog force-pushed the feature/docker-compose-v2 branch from 478232d to 24bdfa7 Compare February 20, 2023 00:38
@jdddog jdddog marked this pull request as ready for review February 21, 2023 01:25
Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes Jamie!

@keegansmith21 keegansmith21 merged commit 32161e4 into develop Feb 21, 2023
@jdddog jdddog deleted the feature/docker-compose-v2 branch August 7, 2023 22:19
jdddog added a commit that referenced this pull request Feb 25, 2024
* Upgrade to Docker Compose V2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants