INF-597: Terraform config files not updating and Flower docker container not building successfully. #598
Conversation
Codecov ReportBase: 92.26% // Head: 92.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #598 +/- ##
===========================================
- Coverage 92.26% 92.25% -0.02%
===========================================
Files 50 50
Lines 6829 6831 +2
Branches 779 780 +1
===========================================
+ Hits 6301 6302 +1
Misses 409 409
- Partials 119 120 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| def copy_dir(source_path: str, destination_path: str, ignore): | ||
| distutils.dir_util.copy_tree(source_path, destination_path) | ||
| def copy_dir(source_path: str, destination_path: str, ignore, update: int = 0): | ||
| distutils.dir_util.copy_tree(source_path, destination_path, update=update) |
There was a problem hiding this comment.
It looks like the update parameter is already set to zero by default in distutils.dir_util.copy_tree, so we shouldn't need to set it.
I seem to have messed up some of this code, because the ignore parameter doesn't get passed to anything. Maybe we were originally using shutil.copytree as that has an ignore parameter? We should probably either remove the ignore parameter or figure out if we could use shutil.copytree which can ignore files with patterns.
87d89cc to
bef78b6
Compare
…ner not building successfully. (#598)
When using the
observatory terraform build-image config.yamlcommand, it was not copying/overwriting terraform config files to the observatory home directory and thus when deploying a new version of the platform to the cloud, it was using the old terraform config. I have now forced the platform to delete the old terraform config files before copying the new ones across from the codebase.After updating the terraform files a strange permissions issue with docker arose, causing the flower container to fail when building the main VM. Have added the appropriate permissions to the /home/packer folder for the airflow user so the Flower container can build successfully.
Waiting on results from the unit tests.