Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precommit rebase fix #579

Merged
merged 1 commit into from
Sep 2, 2022
Merged

precommit rebase fix #579

merged 1 commit into from
Sep 2, 2022

Conversation

keegansmith21
Copy link
Contributor

The pre-commit hook would run into issues during an interactive rebase. The new command fixes the issue but noticing when a rebase is taking place and skipping the commit hook

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #579 (4075e20) into develop (a3c8671) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #579      +/-   ##
===========================================
+ Coverage    93.92%   93.95%   +0.02%     
===========================================
  Files           50       50              
  Lines         6786     6786              
  Branches       765      765              
===========================================
+ Hits          6374     6376       +2     
+ Misses         299      294       -5     
- Partials       113      116       +3     
Impacted Files Coverage Δ
...ry-platform/observatory/platform/utils/gc_utils.py 84.17% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@keegansmith21 keegansmith21 requested a review from jdddog September 2, 2022 00:18
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keegan, it is good to have this fixed!

@jdddog jdddog merged commit bad47e5 into develop Sep 2, 2022
@jdddog jdddog deleted the INF-532_precommit_rebase_fix branch September 2, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants