Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seed_db service in docker-compose #573

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fix seed_db service in docker-compose #573

merged 1 commit into from
Jun 29, 2022

Conversation

aroelo
Copy link
Collaborator

@aroelo aroelo commented Jun 23, 2022

Move seed_db service inside if statement, only create when the backend type is set to 'local'

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #573 (15c68c5) into develop (814cb28) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #573   +/-   ##
========================================
  Coverage    93.96%   93.96%           
========================================
  Files           49       49           
  Lines         6781     6781           
  Branches       763      763           
========================================
  Hits          6372     6372           
  Misses         294      294           
  Partials       115      115           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814cb28...15c68c5. Read the comment docs.

@jdddog jdddog marked this pull request as ready for review June 29, 2022 04:14
@jdddog jdddog self-requested a review June 29, 2022 04:14
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aniek, I'll figure out how to make the seeding work on a remote environment in a different PR.

@jdddog jdddog merged commit faa1d1b into develop Jun 29, 2022
@jdddog jdddog deleted the fix_docker_compose branch June 29, 2022 04:15
jdddog pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants