Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inf 418/add dag tags to workflows #572

Merged
merged 6 commits into from
Jun 29, 2022
Merged

Conversation

tuanchien
Copy link
Collaborator

@tuanchien tuanchien commented Jun 23, 2022

Setting up platform changes for adding vm create/destroy and elastic import workflow tagging.

Ran into an issue when testing locally. Error was similar to:
apache/airflow#22289

which seems to be fixed in Airflow 2.3.0

However, erasing my local postgres db and starting the platform up with clean db did not present the problem.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #572 (53aac30) into develop (faa1d1b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #572      +/-   ##
===========================================
+ Coverage    93.93%   93.97%   +0.03%     
===========================================
  Files           49       50       +1     
  Lines         6781     6783       +2     
  Branches       763      763              
===========================================
+ Hits          6370     6374       +4     
+ Misses         299      294       -5     
- Partials       112      115       +3     
Impacted Files Coverage Δ
...tory/platform/workflows/elastic_import_workflow.py 82.33% <ø> (ø)
...latform/observatory/platform/workflows/workflow.py 93.45% <ø> (-0.04%) ⬇️
...servatory-platform/observatory/platform/dag_tag.py 100.00% <100.00%> (ø)
...form/observatory/platform/workflows/vm_workflow.py 100.00% <100.00%> (ø)
...ry-platform/observatory/platform/utils/gc_utils.py 84.17% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa1d1b...53aac30. Read the comment docs.

@jdddog jdddog force-pushed the INF-418/add_dag_tags_to_workflows branch from 4925aef to 53aac30 Compare June 29, 2022 04:16
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tuan!

@jdddog jdddog merged commit fc2a9bc into develop Jun 29, 2022
@jdddog jdddog deleted the INF-418/add_dag_tags_to_workflows branch June 29, 2022 05:51
jdddog pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants