Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oapen docs #123

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Oapen docs #123

merged 1 commit into from
Feb 14, 2023

Conversation

keegansmith21
Copy link
Contributor

@keegansmith21 keegansmith21 commented Jan 5, 2023

The OAPEN metadata telescope needed a documentation update, as #118 has greatly altered the workflow of the telescope.
Also updated the csv schema generation to work with dateless json schemas, which are now common practice since #116

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 94.76% // Head: 95.18% // Increases project coverage by +0.41% 🎉

Coverage data is based on head (fd7406d) compared to base (a475599).
Patch has no changes to coverable lines.

❗ Current head fd7406d differs from pull request most recent head f12f1ae. Consider uploading reports for the commit f12f1ae to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
+ Coverage    94.76%   95.18%   +0.41%     
===========================================
  Files           23       22       -1     
  Lines         2655     2491     -164     
  Branches       344      328      -16     
===========================================
- Hits          2516     2371     -145     
+ Misses          67       58       -9     
+ Partials        72       62      -10     
Impacted Files Coverage Δ
oaebu_workflows/api_type_ids.py 100.00% <0.00%> (ø)
oaebu_workflows/seed/dataset_info.py 100.00% <0.00%> (ø)
oaebu_workflows/seed/workflow_info.py 100.00% <0.00%> (ø)
oaebu_workflows/seed/organisation_info.py 100.00% <0.00%> (ø)
oaebu_workflows/seed/workflow_type_info.py 100.00% <0.00%> (ø)
oaebu_workflows/workflows/onix_telescope.py 91.94% <0.00%> (ø)
oaebu_workflows/workflows/thoth_telescope.py
oaebu_workflows/workflows/onix_workflow.py 93.98% <0.00%> (+0.12%) ⬆️
...bu_workflows/workflows/oapen_metadata_telescope.py 95.59% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@keegansmith21 keegansmith21 marked this pull request as ready for review January 5, 2023 05:14
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Keegan

@jdddog jdddog merged commit 1f8f055 into develop Feb 14, 2023
@jdddog jdddog deleted the OAPEN_docs branch February 14, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants