Update to embedded-hal v1.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…once_cell, replaced shared-bus with embedded-hal-bus, test doc examples and fixed doc typos
|
Currently the hil tests on cached expander do not pass due to golemparts/rppal#137. Gonna wait until this is resolved and all tests pass. |
|
tests passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded-hal v1.0 has now officially released 🎉 (migration guide blog-post)
pca9535 has already updated to rc2 but rc3 made some changes to the IO traits which might need some general adjustments of the pca9535 crate architecture. Also the general architecture of the crate needs to undergo a check to make sure the crate integrates well into embedded-hal 1.0. One thing that comes to mind is that things like shared-bus are now discouraged to use (looks like only for SPI bus though) so I need to make sure pca9535 works well with the new approaches.