New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up async transaction system a bit #955

Merged

Adlai-Holler merged 2 commits into master from AHCleanupTransactions

Jun 2, 2018

Member

Adlai-Holler commented Jun 2, 2018

Remove unused methods.
- addAsyncOperation we no longer do async rendering.
- addCompletion this was implemented in a somewhat questionable way anyway.
- addOperation without priority. You can just specify default priority.
Implement CALayer category properties using CALayer dynamic properties rather than associated objects.
Tighten up the mainTransactionGroup API and trivial reorg of its implementation.

Adlai Holler added 2 commits

June 2, 2018 09:01


          Clean up async transaction system a bit

cf10901


          Update changelog

fd7e0ad

Adlai-Holler requested review from maicki, garrettmoon, appleguy and nguyenhuy

June 2, 2018 16:05

Adlai-Holler force-pushed the AHCleanupTransactions branch from d4a8119 to fd7e0ad Compare

June 2, 2018 16:14

maicki approved these changes

View reviewed changes

Contributor

maicki left a comment

LGTM

Adlai-Holler merged commit 21973c8 into master

Adlai-Holler deleted the AHCleanupTransactions branch

June 2, 2018 19:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet