Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Faster collection operations" #759

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

Adlai-Holler
Copy link
Member

Reverts #748

I should have marked that diff is not ready to land. I need to address the issue that, if you call mutableCopy on an array created using our custom callbacks, the copy will not retain its objects.

I have a solution, but until I implement it (tonight?) this isn't 100% production-safe.

@ghost
Copy link

ghost commented Jan 22, 2018

1 Warning
⚠️ Please ensure license is correct for ASCollectionGalleryLayoutDelegate.mm:

//
//  ASCollectionGalleryLayoutDelegate.mm
//  Texture
//
//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under the BSD-style license found in the
//  LICENSE file in the /ASDK-Licenses directory of this source tree. An additional
//  grant of patent rights can be found in the PATENTS file in the same directory.
//
//  Modifications to this file made after 4/13/2017 are: Copyright (c) through the present,
//  Pinterest, Inc.  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//

    

Generated by 🚫 Danger

@Adlai-Holler Adlai-Holler merged commit 9b8a919 into master Jan 22, 2018
@Adlai-Holler Adlai-Holler deleted the revert-748-AHFasterCollections branch January 22, 2018 19:38
@nguyenhuy
Copy link
Member

Opps, sorry for jumping the gun here. No need to implement tonight. Enjoy your time off man -- unless you enjoy doing this ¯_(ツ)_/¯ :-)

bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants