[ASDisplayNode] Allow setting stretchable contents on nodes; add bridged properties. #trivial #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged properties. This makes it much easier to use the ASCoreAnimationExtras method which offers by far the most efficient way to display a stretchable image. In the future, we should move that function to UIImage+ASConvenience or another header where it can be more easily found and enjoyed!
appleguy
commented
Jul 9, 2017
| @@ -621,29 +621,32 @@ extern NSInteger const ASDefaultDrawingPriority; | |||
| */ | |||
| - (void)layoutIfNeeded; | |||
|
|
|||
| @property (nonatomic, strong, nullable) id contents; // default=nil | |||
| @property (nonatomic, assign) CGRect frame; // default=CGRectZero | |||
There was a problem hiding this comment.
We should definitely do additional cleanup in this header. However, I made a few improvements (no breaking changes of course) so that the most commonly used properties are more towards the top and more logically grouped.
Because this is still pretty far from ideal, let's not worry too much about optimizing it in this patch - but at least it will be slightly better until we get around to it.
maicki
approved these changes
Jul 9, 2017
| @@ -621,29 +621,32 @@ extern NSInteger const ASDefaultDrawingPriority; | |||
| */ | |||
| - (void)layoutIfNeeded; | |||
|
|
|||
| @property (nonatomic, strong, nullable) id contents; // default=nil | |||
| @property (nonatomic, assign) CGRect frame; // default=CGRectZero | |||
|
@maicki thanks man :) Is there a UIKit method that does this, or you mean UIImageView? |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ged properties. (TextureGroup#429) This makes it much easier to use the ASCoreAnimationExtras method which offers by far the most efficient way to display a stretchable image. In the future, we should move that function to UIImage+ASConvenience or another header where it can be more easily found and enjoyed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to use the ASCoreAnimationExtras method which offers by
far the most efficient way to display a stretchable image.
In the future, we should move that function to UIImage+ASConvenience or another
header where it can be more easily found and enjoyed!