Make interface state delegate non optional #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06e18a1.
|
🚫 CI failed with log |
|
In theory this gonna be an API change. @nguyenhuy @Adlai-Holler @garrettmoon any thoughts? |
Adlai-Holler
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
I think we should go forward with it, with a bold statement in the changelog entry indicating that it's a breaking change.
Adding interface state delegates is a pretty new and somewhat rare technique, the migration pathway is easy, and it's a really hot code path.
maicki
approved these changes
Sep 11, 2018
nguyenhuy
approved these changes
Sep 12, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| ## master | |||
| * Add your own contributions to the next release on the line below this with your name. | |||
| - [ASDisplayNode] Make interface state delegate protocol required. [Max Wang](https://github.com/wsdwsd0829). [#1112](https://github.com/TextureGroup/Texture/pull/1112) | |||
There was a problem hiding this comment.
Let's highlight that it's a breaking change.
|
Build finished successfully although it does not show up. Gonna merge. |
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Make interface state delegate protocol non-optional. * add change log * add missing removal * add required method to ASNodeController * fix indentation * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove respondToSelector check and have better performance.