[License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses). #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
reviewed
Aug 20, 2018
CONTRIBUTING.md
Outdated
| @@ -81,7 +81,7 @@ Before submitting a pull request, please make sure the following is done… | |||
| 6. If you haven't already, sign the CLA. | |||
|
|
|||
| **Copyright Notice for files** | |||
| Copy and paste this to the top of your new file(s): | |||
| Ensure this license header is included on all files in the repository, including new ones: | |||
There was a problem hiding this comment.
So no license mentions in the headers of code files?
README.md
Outdated
| @@ -44,4 +44,4 @@ We welcome any contributions. See the [CONTRIBUTING](https://github.com/textureg | |||
|
|
|||
| ## License | |||
|
|
|||
| The Texture project was created by Pinterest as a continuation, under a different name and license, of the AsyncDisplayKit codebase originally developed by Facebook. AsyncDisplayKit was originally released by Facebook under a BSD license and additional patent grant. Those BSD and patent licenses govern use of code in Texture contributed prior to 4/13/2017 (the original AsyncDisplayKit code), and copies of the licenses are included in the root directory of this source tree for reference. All code contributed to Texture after 4/13/2017 is released by Pinterest under an Apache 2.0 license. | |||
| The Texture project is available for free use, as described by the Apache 2.0 license. Texture is based on code from the AsyncDisplayKit project originally developed by Facebook. Although AsyncDisplayKit was originally released by Facebook under a BSD license and additional "PATENTS v2" grant, the entire Texture codebase is now under a unified Apache 2 license with approval from Facebook to remove the PATENTS v2 file (including for the AsyncDisplayKit fork from 4/13/17). | |||
There was a problem hiding this comment.
Not sure we need the second sentence any longer. I think you can remove all references to the old license.
…ASDK-Licenses) With permission of the Facebook Open Source team, we are simplifying the Texture license so that clients can rely on the Apache 2 terms that most of Texture is already covered by. This means that code originally forked from AsyncDisplayKit will be re-licensed from "BSD 3-clause + PATENTS v2" to Apache 2 without a PATENTS file. After getting confirmation that the updates to these core files look good, we'll propagate this new license header to all files (in this same PR) and get sign-off from all parties before landing.
471e9e9 to
4467acb
Compare
Adlai-Holler
approved these changes
Aug 21, 2018
|
Good branch name 😁 |
|
I am just clarifying a couple more things, but we are close to being able to merge this. |
JoelMarcey
suggested changes
Aug 21, 2018
This reverts commit ffa0fbb.
…ining copyrights.
Generated by 🚫 Danger |
|
🚫 CI failed with log |
JoelMarcey
approved these changes
Aug 27, 2018
|
@JoelMarcey Thanks for letting us know - will merge now. |
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…ASDK-Licenses). (TextureGroup#1077) * [License] Simplify the Texture license to be pure Apache 2 (removing ASDK-Licenses) With permission of the Facebook Open Source team, we are simplifying the Texture license so that clients can rely on the Apache 2 terms that most of Texture is already covered by. This means that code originally forked from AsyncDisplayKit will be re-licensed from "BSD 3-clause + PATENTS v2" to Apache 2 without a PATENTS file. After getting confirmation that the updates to these core files look good, we'll propagate this new license header to all files (in this same PR) and get sign-off from all parties before landing. * [License] Update all Texture source files to be pure Apache 2. * Changelog entry for Apache 2 license update. * Revert "[License] Update all Texture source files to be pure Apache 2." This reverts commit ffa0fbb. * [License] Update all Texture source files to be pure Apache 2, maintaining copyrights. * [License] Update CONTRIBUTING, README, Podspec & Dangerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With permission of the Facebook Open Source team, we are simplifying the Texture license, so that clients can rely on the terms of the Apache 2 license for all code in the Texture project.
This means that code originally forked from AsyncDisplayKit will be re-licensed from "BSD 3-clause + PATENTS v2" to Apache 2 (which includes a built-in patents grant).
Summarizing the change:
There may be a bit of iteration to get everything right since this is such a large change. @JoelMarcey is the Facebook representative who is authorized to review this change.