Resolve Concurrency Issues in Iceberg Tables and Eliminate Scala Compiler Warnings #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
reviewed
Mar 4, 2025
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/model/VirtualDocument.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/service/WorkflowService.scala
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/texera/web/service/ExecutionStatsService.scala
Show resolved
Hide resolved
...flow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/iceberg/IcebergDocument.scala
Outdated
Show resolved
Hide resolved
bobbai00
approved these changes
Mar 4, 2025
core/amber/src/main/scala/edu/uci/ics/texera/web/service/WorkflowService.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the concurrency issues that emerged in the console messages and runtime statistics Iceberg tables following the integration of PRs #3286 and #3281. The aggressive removal of old snapshots and metadata in those earlier changes caused failures during concurrent read and write operations. To resolve this, snapshots and metadata are now lazily removed—triggered either when a workflow restarts or upon lifecycle expiration.
Additionally, this update removes the Scala compiler warnings that were previously occurring during code compilation.