Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize source code for Elements; obsolete those we don't use #1174

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

CharliePoole
Copy link
Contributor

Fixes #1170

@rowo360
Copy link
Contributor

rowo360 commented Jan 18, 2025

The Readme.md file really provides a perfect summary of the fundamental design approach. It is really beneficial that it is now written down so that everyone can take this into account in the future.
You have also listed each interface and class by name and explained its primary purpose - that's a good overview!
Of course this file should be maintained now, when adding new classes/interface to the Elements folder.

Copy link
Contributor

@rowo360 rowo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - it will help to keep the design.
(Minor issue - I adapted one spelling issue in the Readme file myself)

@rowo360
Copy link
Contributor

rowo360 commented Jan 18, 2025

This PR is assigned to me, so I assume that I should learn to review and merge a PR. :-)
As it looks fine for me, I'll do the merge now.

@rowo360 rowo360 merged commit 51e5c2f into main Jan 18, 2025
2 checks passed
@rowo360 rowo360 deleted the issue-1170 branch January 18, 2025 08:43
@CharliePoole
Copy link
Contributor Author

Thanks. Hopefully, having the file right there in the directory should help us keep it up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure Elements Directory for clarity and add a README
2 participants