-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the TerriaJS experience on mobile devices, especially phones #822
Conversation
The Chrome device emulator issue is fixed in Leaflet/Leaflet#3520, which is in the Leaflet stable branch. |
The menu buttons could stay visible with: @media screen and (max-width: 700px), screen and (max-height: 420px) {
.menu-bar-item {
display: block;
text-align: center;
margin-bottom: 10px;
}
} Then the compass and navigation-controls can either also be pushed down (and centred with the menu buttons) or just hidden as they are now. |
Nice, thanks. We're currently using 0.7.3 via npm. Hopefully there will be a 0.7.4 before too long.
Doesn't look very good, does it? I think a hamburger menu type of thing is the better approach, but I'm happy to wait for Phil's complete mobile design rather than hacking that in now. |
Ah, my bad, I think they should stay hidden below 550px, but stack up below 900px (the navigation/compass would need to move down), but I agree that it should probably just wait till a proper design. |
I still think that starting with the map rather than the data menu is a better way to go. On my phone there is virtually no indication (a few pixels of blue/black pixels that merge with the screen frame) that there is a map anywhere and selecting things from the data catalog/now viewing/search does display it. The only way to get to the map is the faint < symbol in the upper right. If people miss that they're done and since starting on a menu is uncommon, most users will probably not know what to do. Bringing up a menu via the data catalog button on the other hand will be pretty clear to most phone users. |
@hilarycinis have you tried out the demo on a phone or anything? We've just gone from "totally, embarassingly broken" to "sort of works ok." The message about small screens not being well supported is still there and we won't get rid of it until we have an actual mobile design. re: Keith's suggestion, I was resistant to the idea when Keith mentioned it yesterday, but I'm coming around. I'll do that, assuming @hilarycinis and @philipgrimmett don't have any objections. |
I am literally making this up on the fly to help with the decision making around the navigation and buttons stacking over the catalog/viewing/search bar. If you have a different treatment for screens under 900px wide, you can make better use of the layout to have both map, header and navigation. |
I think we're all agreed we're not going to worry about the navigation controls or menu buttons (and just remove them entirely, as is done in the current demo linked above) for now. We'll revisit for the real mobile design, of course, but that's separate from this pull request. |
Sorry, only just saw your demo link in the start of this thread. I fully agree, collapse the data cat so the map is seen on loading. |
OK, so I'm assuming we're all ok with this now. This merge will be what's at http://nationalmap.research.nicta.com.au/kring with the data menu hidden to start. This will be upgraded to the 'real' mobile design when that is ready. If that's not the case, let me know and I'll hold off merging. |
Lovely! On Fri, Jul 10, 2015 at 12:03 AM -0700, "Keith Grochow" <notifications@github.commailto:notifications@github.com> wrote: OK, so I'm assuming we're all ok with this now. This merge will be what's at http://nationalmap.research.nicta.com.au/kring with the data menu hidden to start. This will be upgraded to the 'real' mobile design when that is ready. If that's not the case, let me know and I'll hold off merging. — The information in this e-mail may be confidential and subject to legal professional privilege and/or copyright. National ICT Australia Limited accepts no liability for any damage caused by this email or its attachments. |
This is far from perfect, but it's much less embarrassing than what we had before.
Terria.start
to default to 2D. National Map will use this to default to 2D on any browser with "Android", "iPhone", "iPad", "Windows Phone", or "IEMobile" in its user agent. This saves CPU, battery life, and bandwidth. If you want to play with 3D, add#map=3d
to the URL.Live demo is here:
http://nationalmap.research.nicta.com.au/kring
For some reason (still unknown after quite a while spent trying to figure it out), panning doesn't work in Leaflet in the Chrome device emulator. It works fine in Cesium and on my actual Nexus 5. Hopefully it's just a Chrome quirk, but let me know if panning also doesn't work on your iPhones or whatnot.