Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: leverage #18 for docsify-based module documentation #65

Merged
merged 15 commits into from
Apr 18, 2021

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Apr 18, 2021

Outstanding:

  • add module banner
  • merge with wiki docs (I unfortunately only became aware of a minute ago 🙄 )

Co-authored-by: oniatus oniatus@googlemail.com
Co-authored-by: Quinn Roberts quinn@jelly-snakes.com

@jdrueckert jdrueckert added the Type: Improvement Request for or addition/enhancement of a feature label Apr 18, 2021
@jdrueckert jdrueckert requested a review from skaldarnar April 18, 2021 20:04
@jdrueckert jdrueckert self-assigned this Apr 18, 2021
docs/index.html Outdated
<html lang="en">
<head>
<meta charset="UTF-8">
<title>TeraNUI</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what I put here for Health 🤔 maybe Terasology/GooeyDefence?

They spawn in the outer areas of the gameplay arena and try to traverse it to reach the shrine in the arena center.

Currently, Gooeys do not spawn automatically.
A wave of Gooeys can be triggered by interacting with the shrine in the center of the arena (`E`) or by using a held item (right-click).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun fact - you can use <kbd>E</kbd> to denote keys: E

docs/towers.md Outdated
Comment on lines 22 to 29
| Effector | Effect | Notes |
-------------------------------------------------------------------------
| DamageEffector | Plain Damage | direct damage only |
| FireEffector | Burn Damage | damage over time, chance of spreading |
| IceEffector | Slow | |
| PoisonEffector | Poison | damage both direct and over time |
| StunEffector | Stun | |
| VisualEffector | Enlarge | increases enemy visibility |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this table does not render correctly. same for the one below:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pipe | is missing in the horizontal divider line.

docs/_sidebar.md Outdated
* [TowerScreen](tower-screen.md)
* [Parsers](parsers.md)
* API
* [API](http://jenkins.terasology.io/teraorg/job/Terasology/job/Modules/job/G/job/GooeyDefence/job/master/javadoc/overview-summary.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this module does not have a master branch, therefore this link is broken. I'm not sure what the correct link to the last "release" would be, maybe best to just remove this.

Suggested change
* [API](http://jenkins.terasology.io/teraorg/job/Terasology/job/Modules/job/G/job/GooeyDefence/job/master/javadoc/overview-summary.html)

@jdrueckert jdrueckert changed the title doc: improve GooeyDefence documentation doc: leverage #18 for docsify-based module documentation Apr 18, 2021
@jdrueckert jdrueckert merged commit d7ec3f3 into develop Apr 18, 2021
@jdrueckert jdrueckert deleted the doc/update-pr-18 branch April 18, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants