-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add subject template group api #273
Merged
zhu327
merged 11 commits into
TencentBlueKing:develop
from
zhu327:feat_subject_template
Nov 30, 2023
Merged
feat: add subject template group api #273
zhu327
merged 11 commits into
TencentBlueKing:develop
from
zhu327:feat_subject_template
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wklken
reviewed
Oct 25, 2023
GroupPK int64 | ||
ExpiredAt int64 | ||
|
||
NeedUpdate bool // 是否需要更新subject system group, 默认为false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
名字上更明确些, NeedUpdateSubjectSystemGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
实际上除了subject system group需要变更外, 还需要变更除了当前数据的其它的subject relation与subject template group, 所以不是很好定义这个名字
wklken
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更点(Changes)
相关issues (Which issues this PR fixes)
备注(Special notes)