Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): 修复Slider部分属性丢失响应性问题 #683

Merged
merged 2 commits into from
May 1, 2022

Conversation

ChrisLee0211
Copy link
Contributor

fix #664

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#664

💡 需求背景和解决方案

关于marks属性在进行compostion Api重构时是以静态属性来设计的,现在改为响应性属性,同时顺带修复marks点击事件无效问题

📝 更新日志

  • fix(Slider): 将marks属性更改为响应性属性,并内部修复marks刻度节点点击事件无效问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@cc12303). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #683   +/-   ##
==========================================
  Coverage           ?   60.92%           
==========================================
  Files              ?      402           
  Lines              ?    13902           
  Branches           ?     2608           
==========================================
  Hits               ?     8470           
  Misses             ?     5193           
  Partials           ?      239           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc12303...3becc2e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

完成

@PengYYYYY PengYYYYY merged commit 66fa54a into Tencent:develop May 1, 2022
@94dreamer 94dreamer mentioned this pull request May 6, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[t-slider] max和min无法通过ref动态修改
3 participants