Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix warning when type of option value is boolean #4932

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

SaberA1ter
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#4922

💡 需求背景和解决方案

需求背景:option 组件 value 原类型为 string | number,在使用 boolean 类型时控制台打印 vue 类型错误警告

解决方法:添加 boolean

📝 更新日志

  • fix(select): 修复 option value 为 boolean 时控制台类型错误警告

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Jan 17, 2025

完成

@uyarn
Copy link
Collaborator

uyarn commented Jan 17, 2025

还有地方需要补充boolean类型 根据lint提示补充完整

@uyarn uyarn changed the title fix(select): 修复 option value 为 boolean 时控制台类型错误警告(#4922) fix(select): fix warning when type of option value is boolean Jan 19, 2025
@uyarn
Copy link
Collaborator

uyarn commented Jan 19, 2025

还有 md 文件需要修改 由 @msg-fobbit 再提交 pr

@uyarn uyarn merged commit d5a048a into Tencent:develop Jan 19, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants